pagecache: fix on-demand mapping of evicted pages #2016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page fault occurs on a file-backed mapping for a page that was previously in the page cache but has later been evicted, the fault handler calls pagecache_map_page_if_filled(), which should return
false
because the newly re-allocated page has not been filled yet. Commit 132a832 introduced a regression which causes pagecache_map_page_if_filled() to returntrue
instead; this leads to page cache contents inconsistent with file contents and erroneous data accessed by the user program via the file-backed mapping.This change fixes the above issue by amending the touch_or_fill_page_nodelocked() function so that it returns
false
when the relevant page is in the ALLOC state.